RedHatInsights / topological_inventory-api

Apache License 2.0
2 stars 24 forks source link

Metrics env check fix + Gitignore to grafana JSON files and link to doc #323

Closed slemrmartin closed 3 years ago

slemrmartin commented 3 years ago

Issue: https://github.com/RedHatInsights/topological_inventory-api/issues/320

Just a small addition to #322. Gragana dashboard changes have to be exported to JSON as frequently as possible because you never know when it will be replaced by appsre.

And JSONs are then converted to configmaps, so storing them locally in the same folder makes sense to me.

This PR also adds a link to documentation in Topological Inventory Guides.

EDIT: Changed check for ENV["METRICS_PORT"] which is not ignoring default settings


RHCLOUD-9941

dippy-bot commented 3 years ago

Checked commits https://github.com/slemrmartin/topological_inventory-api/compare/667386a15de8d64b843d6e0f3a196205b57a0ffc~...ae434c670b9af62792dd8f687db9f6b6c5236b4a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :star: