Incorrect use of parameters during provisioning - Githubissues

RedHatInsights / topological_inventory-core

Apache License 2.0

2 stars 18 forks source link

Incorrect use of parameters during provisioning #75

Open mkanoor opened 5 years ago

mkanoor commented 5 years ago

https://github.com/ManageIQ/topological_inventory-core/blob/dbceaa98c2499a49a6eb8725d46c1114a2fbe1e5/lib/topological_inventory/core/service_plan_client.rb#L10

The service portal is sending the namespace to use (default for now) for provisioning in the provider control parameters.

The provider control parameters is being merged with service parameters which is incorrect. https://github.com/eclarizio/topological_inventory-api/blob/2329cb746e79b3950a053b9992cffb775eff10da/app/controllers/api/v0/service_plans_controller.rb#L18

We have to keep the 2 parameters separate till we are ready to order

service_parameters goes here https://github.com/ManageIQ/topological_inventory-core/blob/dbceaa98c2499a49a6eb8725d46c1114a2fbe1e5/lib/topological_inventory/core/service_plan_client.rb#L15
provider_control_parameters a hash has the 'namespace' https://github.com/ManageIQ/topological_inventory-core/blob/dbceaa98c2499a49a6eb8725d46c1114a2fbe1e5/lib/topological_inventory/core/service_plan_client.rb#L10

mkanoor commented 5 years ago

@eclarizio @agrare