RedHatInsights / tower-analytics-frontend

Automation Analytics provides data analytics for Ansible Tower that provides visualization and insight into how automation is used in your organization.
https://console.redhat.com/ansible/ansible-dashboard
Apache License 2.0
9 stars 28 forks source link

[AA-1791] fix api calls in report tiles #990

Closed daphnemaeve closed 11 months ago

daphnemaeve commented 1 year ago

Jira issue: https://issues.redhat.com/browse/AA-1791

This PR fixes the excessive API calls made when clicking on a card to preview a report in the reports view. This was tested by putting a console.log statement in the useEffect in src/Containers/Reports/List/List.tsx, on line 97, as well as by looking at the API calls made in the Network tab when inspecting the page.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/Containers/Reports/List/ListItem/index.tsx 0.00% <0.00%> (ø)
src/Containers/Reports/List/List.tsx 0.00% <0.00%> (ø)

... and 18 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.

cypress[bot] commented 11 months ago

1 flaky test on run #1706 ↗︎

0 66 2 0 Flakiness 1

Details:

Merge branch 'devel' into AA-1791_fix_api_calls_in_report_tiles
Project: tower-analytics-frontend Commit: 3f24ef0c71
Status: Passed Duration: 07:49 💡
Started: Oct 30, 2023 2:26 PM Ended: Oct 30, 2023 2:33 PM
Flakiness  cypress/e2e/Clusters.spec.js • 1 flaky test View Output Video
Test Artifacts
Clusters page > Hover over each bar in bar chart Test Replay Output Screenshots

Review all test suite changes for PR #990 ↗︎