RedHatInsights / yggdrasil

GNU General Public License v3.0
21 stars 37 forks source link

Support hyphenated directive names with a warning #210

Closed subpop closed 6 months ago

subpop commented 7 months ago

The D-Bus object name specification does not permit hyphens (dashes) in the name. For example, com.redhat.Yggdrasil1.Worker1.rhc-worker-playbook is not valid. Underscores are valid. Workers using yggdrasil >= 0.3 that include hyphens in their directive string will need to update to using underscores. To support existing directives, yggdrasil should permit hyphens, but should log a warning.

~In the worker package, this error should be replaced with a warning, and the hyphens should be replaced with underscores.~

In the internal/work package, before looking for a worker, the hyphens should be replaced with underscores.

~In libygg, the ygg_worker_connect method should log a warning and replace hyphens with underscores.~