Open jirihnidek opened 6 months ago
I have been thinking this over. With the recent change to a facts files (in #221), tags and facts are semantically identical. Is there a reason to keep both? Should we drop one and keep the other?
It seems that tags and facts are supported in yggdrasil-0.2 (rhcd)
Would not break such change (drop e.g. tags) backward compatibility? I mean, would not create it another engineering problem? Tags are stored in toml file. Facts are stored in JSON file. If one is dropped, then we should support some conversion script. Is it worth dropping one file?
Yes, it would break backwards compatibility. We've already done that between 0.2 and 0.3 though, the D-Bus changes, as well as:
--broker
flag has been replaced by a --server
flag.That's partly why I'm considering this idea.
Describe the bug If you open fact file or tag file in editor (eg. vim), then monitoring of these files does not work, because vim triggers other events than
notify.InCloseWrite
ornotify.InDelete
. vim triggers two events:notify.Rename
andnotify.Remove
To Reproduce Steps to reproduce the behavior:
yggd
with some fact file using:/path/to/file.facts
in vim, edit the file and save it.Expected behavior Change of file is detected and new connection status is sent.
Current behavior No change is detected