Disable "Use Typo Metrics"

RedHatOfficial / Overpass

Overpass open source web font family — Sponsored by Red Hat

http://overpassfont.org

SIL Open Font License 1.1

2k stars 89 forks source link

Disable "Use Typo Metrics" #66

Closed aaronjensen closed 4 years ago

aaronjensen commented 6 years ago

Fixes #56

This fixes the line height issues that are visible on Firefox on all platforms and other browsers on Windows. It's possible that this will change rendering in some places where it isn't desirable, but it fixes it and allows centering in some pretty common use-cases like buttons on redhat.com:

Firefox	Chrome

Note that the fonts will need to be regenerated if this is applied, I only updated the sources and there are no generation instructions that I could find.

olokobayusuf commented 5 years ago

Any word on when this will be reviewed/merged?

setur52 commented 5 years ago

Are there any updates on this? The problem is really important on windows

stephane-r commented 5 years ago

Same problem, any updates ? Maybe need more information for local compile ?

castastrophe commented 5 years ago

@andyfitz If you have time, I'd love your input on this PR. I'm more involved in this project from a technical perspective to assist with build tools, sass, or rolling releases.

keeganhrobinson commented 4 years ago

Hey @castastrophe or @andyfitz. I'm experiencing this issue as well. Is there anything I can do to help get this merged in? I'd love for the text on our website buttons to be vertically aligned the same across browsers.

madig commented 4 years ago

(chiming in to mention https://bugzilla.mozilla.org/show_bug.cgi?id=1597680 -- vertical text alignment seems to be trickier than just UseTypoMetrics)

ForLoveOfCats commented 4 years ago

Whether or not this is a conclusive fix for the issue it saved my butt so I'm here to save a heartfelt thanks!

andyfitzsuse commented 4 years ago

thanks @ForLoveOfCats I've merged the pull request

andyfitzsuse commented 4 years ago

@aaronjensen you legend, I really should have checked this sooner, It's in the latest release !

aaronjensen commented 4 years ago

Awesome, thanks for the merge, @andyfitz! Are you able to regenerate the font files in this repo as well?

michaelfaith commented 3 years ago

@aaronjensen you legend, I really should have checked this sooner, It's in the latest release !

@andyfitz Seems to be a pending build for this. The fix hasn't matriculated to the various font hosts, as a result. There's an open PR to merge the new built files. Possible to get this through?