search

RedHatOfficial / Overpass

Overpass open source web font family — Sponsored by Red Hat
http://overpassfont.org
SIL Open Font License 1.1
2k stars 89 forks source link

Please build release 3.0.4 #75

Closed gforrest-bw closed 3 years ago

gforrest-bw commented 4 years ago

Commented this on another issue, but I'm not sure it was seen.

I appreciate the work done to fix the line height rendering issues in PR #66. The repo may list v3.0.4 which "officially" releases this fix, but the webfonts have not been built in the last 2 years, so there's still no way for anyone without licensed software to use the font. Google Fonts doesn't seem to have updated either.

Since the work has already been put in, it would be shame to let it go to waste! If nothing else, can you build the webfonts using the required software and push them to the repo so we can self-host a fixed version?

If I'm mistaken, please direct me to a copy of the built font and I'll be on my way!

kosmosjamaa commented 4 years ago

any update on the build that fixes the line height issue?

iLaurens commented 4 years ago

Thanks for spotting this, I updated to 3.0.4 hoping the line-height issue was fixed. If there are instructions how to build the font from the source folder I'd be happy to assist.

gutdingwillweilehaben commented 4 years ago

Hi, I'm also looking for the latest build of the font. Is there already a new build available?

stephenreid321 commented 4 years ago

I'm also looking for the latest build!

kosmosjamaa commented 4 years ago

@stephenreid321 @gutdingwillweilehaben here are generated font files from the latest glyps. i dont have push access so i'll just drop a mediafire link https://www.mediafire.com/folder/eymuy8imqcpgx/

stephenreid321 commented 4 years ago

Thanks!

gforrest-bw commented 4 years ago

@kosmosjamaa May I suggest forking the repo and issuing a PR with these files included? MediaFire is not the most convenient method of downloading (they require you to pay to download multiple files at once... in 2020!)

I'll do it once I have them all downloaded if you'd like, just figured as you were the one that finally corrected the situation, you might want to be the one to contribute the fix!

teleyinex commented 3 years ago

Any updates on this? Otherwise I'm happy to send the PR myself :-) Just downloaded all the fonts.

teleyinex commented 3 years ago

Quick follow up, as it was easy, I've sent you a PR: https://github.com/RedHatOfficial/Overpass/pull/84

All the acknowledgments should go to @kosmosjamaa!

michaelfaith commented 3 years ago

Will this be released soon? Our corporation was planning to adopt this font as part of its design standard, and this line height issue has become a blocking issue.

70nyIT commented 3 years ago

I highly suggest you guys to re-built it. I have been struggling a lot as I was importing the font from Google Fonts, and having issue with the line-height too. I think that Google Fonts gets the latest build and not the actual files in the repo. You can see it in this codesandbox, where you clearly see text is not centered in the button https://codesandbox.io/s/unruffled-vaughan-zvwq9

If I clone the repo files, of course, everything is fine

michaelfaith commented 3 years ago

@70nyIT there's already an issue in Google Fonts' github to update with the latest build. They don't automatically injest what was built here. https://github.com/google/fonts/issues/2665

70nyIT commented 3 years ago

yes, seen that issue @michaelfaith. What's sure is that downloading the latest build without the latest file in it can be confusing, like have been for me and other users

michaelfaith commented 3 years ago

Oh, do you mean the zip attached to the 3.0.4 tag? That's true. Maybe they should create a new tag?

70nyIT commented 3 years ago

yes, exactly. If you see the "release" section it bring you to this page https://github.com/RedHatOfficial/Overpass/releases/tag/3.0.4

I think to avoid confusion a 3.0.5 should be released with the latest build

michaelfaith commented 3 years ago

Agreed, that would be the safest way to avoid confusion.

michaelfaith commented 3 years ago

@70nyIT they made the 3.0.5 release today, if you want to pull it now.