search

RedHatOfficial / RedHatFont

Red Hat's Open Source Fonts - Red Hat Display and Red Hat Text
SIL Open Font License 1.1
479 stars 55 forks source link

Enable fsSelection bit 6 for non-RIBBI fonts #23

Closed benkiel closed 5 years ago

benkiel commented 5 years ago

This is a remake of #22, with a version number bump for the fonts. It sets the OS/2 fsSelection bit 6 to on for both the TTF and OTF fonts. Comparison, as @m4rc1e had in his pull is below.

Bold

names modified: 4

id string_a string_b
(3, 1, 0, 0) 1.003;MCKL;RedHatText-Bold 1.005;MCKL;RedHatText-Bold
(3, 3, 1, 1033) 1.003;MCKL;RedHatText-Bold 1.005;MCKL;RedHatText-Bold
(5, 1, 0, 0) Version 1.003; Red Hat Text Bold Version 1.005; Red Hat Text Bold
(5, 3, 1, 1033) Version 1.003; Red Hat Text Bold Version 1.005; Red Hat Text Bold

attribs modified: 2

table attrib value_a value_b
head modified 2019/04/08 14:50:54 2019/07/09 16:23:27
head fontRevision 1.00299 1.00499

Bold Italic

names modified: 4

id string_a string_b
(3, 1, 0, 0) 1.003;MCKL;RedHatText-BoldItalic 1.005;MCKL;RedHatText-BoldItalic
(3, 3, 1, 1033) 1.003;MCKL;RedHatText-BoldItalic 1.005;MCKL;RedHatText-BoldItalic
(5, 1, 0, 0) Version 1.003; Red Hat Text Bold Italic Version 1.005; Red Hat Text Bold Italic
(5, 3, 1, 1033) Version 1.003; Red Hat Text Bold Italic Version 1.005; Red Hat Text Bold Italic

attribs modified: 3

table attrib value_a value_b
OS/2 fsSelection 801 289
head fontRevision 1.00299 1.00499
head modified 2019/04/08 14:50:54 2019/07/09 16:23:27

Regular

names modified: 4

id string_a string_b
(3, 1, 0, 0) 1.003;MCKL;RedHatText-Regular 1.005;MCKL;RedHatText-Regular
(3, 3, 1, 1033) 1.003;MCKL;RedHatText-Regular 1.005;MCKL;RedHatText-Regular
(5, 1, 0, 0) Version 1.003; Red Hat Text Version 1.005; Red Hat Text
(5, 3, 1, 1033) Version 1.003; Red Hat Text Version 1.005; Red Hat Text

attribs modified: 2

table attrib value_a value_b
head modified 2019/04/08 14:50:55 2019/07/09 16:23:28
head fontRevision 1.00299 1.00499

Italic

names modified: 4

id string_a string_b
(3, 1, 0, 0) 1.003;MCKL;RedHatText-Italic 1.005;MCKL;RedHatText-Italic
(3, 3, 1, 1033) 1.003;MCKL;RedHatText-Italic 1.005;MCKL;RedHatText-Italic
(5, 1, 0, 0) Version 1.003; Red Hat Text Italic Version 1.005; Red Hat Text Italic
(5, 3, 1, 1033) Version 1.003; Red Hat Text Italic Version 1.005; Red Hat Text Italic

attribs modified: 3

table attrib value_a value_b
OS/2 fsSelection 769 257
head modified 2019/04/08 14:50:54 2019/07/09 16:23:28
head fontRevision 1.00299 1.00499

Medium

names modified: 4

id string_a string_b
(3, 1, 0, 0) 1.003;MCKL;RedHatText-Medium 1.005;MCKL;RedHatText-Medium
(3, 3, 1, 1033) 1.003;MCKL;RedHatText-Medium 1.005;MCKL;RedHatText-Medium
(5, 1, 0, 0) Version 1.003; Red Hat Text Medium Version 1.005; Red Hat Text Medium
(5, 3, 1, 1033) Version 1.003; Red Hat Text Medium Version 1.005; Red Hat Text Medium

attribs modified: 3

table attrib value_a value_b
OS/2 fsSelection 256 320
head fontRevision 1.00299 1.00499
head modified 2019/04/08 14:50:54 2019/07/09 16:23:27

Medium Italic

names modified: 4

id string_a string_b
(3, 1, 0, 0) 1.003;MCKL;RedHatText-MediumItalic 1.005;MCKL;RedHatText-MediumItalic
(3, 3, 1, 1033) 1.003;MCKL;RedHatText-MediumItalic 1.005;MCKL;RedHatText-MediumItalic
(5, 1, 0, 0) Version 1.003; Red Hat Text Medium Italic Version 1.005; Red Hat Text Medium Italic
(5, 3, 1, 1033) Version 1.003; Red Hat Text Medium Italic Version 1.005; Red Hat Text Medium Italic

attribs modified: 3

table attrib value_a value_b
OS/2 fsSelection 769 257
head fontRevision 1.00299 1.00499
head modified 2019/04/08 14:50:55 2019/07/09 16:23:28
m4rc1e commented 5 years ago

Thank you! just had a quick look and it's perfect!

Regarding the Oblique bit, I simply wanted it disabled for Italic styles which has happened.

@starryeyez024 This can be merged. I'll then push the fonts to google/fonts.

starryeyez024 commented 5 years ago

Tested locally, this looks good, though we also need a changelog update please & thanks! @benkiel @m4rc1e something like this:

## 2.3.1 (2019-07-16)
Tag: [2.3.1](https://github.com/RedHatOfficial/RedHatFont/commits/2.3.1)

- Set the OS/2 fsSelection bit 6 to on for both the TTF and OTF fonts
- Disable oblique... ?
benkiel commented 5 years ago

@starryeyez024 Done!