search

RedHatOfficial / RedHatFont

Red Hat's Open Source Fonts - Red Hat Display and Red Hat Text
SIL Open Font License 1.1
479 stars 55 forks source link

backticks overlaping other characters "Red Hat Mono" and "Red Hat Display" #43

Open KunalTanwar opened 2 years ago

KunalTanwar commented 2 years ago

VS Code image

In Notepad image

In MS Word image

In Chrome image

Edge image

Figma Group 23

notklaatu commented 2 years ago

I'm also experiencing this.

Here's Red Hat Text in LibreOffice (note a backtick incorrectly over the c):

Screenshot_20220503_061033

jeremymickel commented 2 years ago

@KunalTanwar @notklaatu @mpieczaba

We have a fix for this, will be implementing it soon.

wesruv commented 2 years ago

Just ran into this on the customer portal in prod :( looking forward to the fix.

wesruv commented 2 years ago

@jeremymickel does this mean we can download an updated version from Google fonts?

I'm pretty sure that we just found this issue in Red Hat Text as well.

wesruv commented 2 years ago

This can be closed IMO

notklaatu commented 2 years ago

This can be closed IMO

I disagree. This issue has not been fixed in this repository (or at least, the release version doesn't reflect the fix.)

If the issue has been fixed, it should be merged here and released.

mpieczaba commented 2 years ago

This issue has not been fixed in this repository

I think there is another repo (I don't know which one is canonical) and there, as far as I can remember, this issue is fixed.

notklaatu commented 2 years ago

I see now that updates aren't happening in this repo. It seems non-optimal for the official home of the font to not be receiving updates. I'll file a new bug about that.

wesruv commented 2 years ago

@notklaatu @mpieczaba sorry I didn't catch that other folks were waiting, the fix is here: https://github.com/RedHatOfficial/RedHatFont/pull/49

It's looking good to me, but I'm trying to get more formal QA on it, I think that's what we're waiting on the merge for.

Re: the two repos: I got confused by the two repos as well, but got the story on that recently. The typographyer's repo is upstream of this one, but we don't use the webfont from there. The font weight ends up being too light for the screen, this repo removes some of the lighter weights of the webfont so font-weight: 400 reads well.

The typographer was able to fix this issue a while back but confusion on the two repos, but no one was clear on how to get those updates to this repo and recompile. In the MR above I think we got it.