RedHatOfficial / miq-RedHat-Satellite6

ManageIQ Automate Domain for integrating with Red Hat Satellite 6 developed by Red Hat Consulting.
GNU General Public License v3.0
18 stars 7 forks source link

Add exception handling and retry capability when making API satellite calls #95

Open A-Beck opened 5 years ago

A-Beck commented 5 years ago

Currently, we do not handle intermittent connection timeouts/connection refused errors as well as we could.

i.e dialogs https://github.com/RedHatOfficial/miq-RedHat-Satellite6/blob/master/Automate/RedHatConsulting_Satellite6/Integration/Satellite/DynamicDialogs.class/__methods__/get_hostgroups.rb#L87

i.e method https://github.com/RedHatOfficial/miq-RedHat-Satellite6/blob/master/Automate/RedHatConsulting_Satellite6/Integration/Satellite/Operations/Methods.class/__methods__/register_satellite.rb#L310

In the cases where we do catch possible exceptions, we do not attempt to retry.

It would be great if we caught exceptions and added retry capability to make this code more robust.