RedHatOfficial / ocp4-vsphere-upi-automation

Automates most of the manual steps of deploying OCP4.x cluster on vSphere
MIT License
131 stars 107 forks source link

Automation to lay down F5 config for UPI deployment #103

Closed bmarlow closed 1 year ago

bmarlow commented 1 year ago

Automation will create: TCP based VIPs for API and APP endpoints

API VIP is 6443 APP VIP is 80 and 443

Respective pools and node members are configurable in size by adding more nodes into the appropriate dictionaries.

ddreggors commented 1 year ago

I see the new role here but I do not see any code changes to use this role.

How can we test this role and verify it if nothing calls it in the playbooks? Can we rename this role to something that says F5 BigIP?

Generally, we would make use of a when clause in the playbook when importing roles like this that allows us to pass a variable (often boolean) that decides whether we use this role.

bmarlow commented 1 year ago

Fair points, thanks for the direction.

I've updated it so that it whenever the common tasks are run, if the F5 var is enabled it will run the F5 config.

It has also been refactored so that it uses the existing role variables wherever possible.

ddreggors commented 1 year ago
PLAY RECAP ************************************************************************************************************************************************************************************************************************************************************************************************************
localhost                  : ok=105  changed=47   unreachable=0    failed=0    skipped=30   rescued=0    ignored=0 

The latest changes were tested, and the cluster was built with the F5 role used. Cluster and F5 changes all checked out.