search

RedHatOfficial / ocp4-vsphere-upi-automation

Automates most of the manual steps of deploying OCP4.x cluster on vSphere
MIT License
131 stars 107 forks source link

Consider supporting more networktype: OVNKubernetes #74

Closed pichuang closed 3 years ago

pichuang commented 3 years ago

Could we consider refactor those codes to support OVNKubernetes?

https://github.com/RedHatOfficial/ocp4-vsphere-upi-automation/blob/master/roles/common/tasks/isolation_mode.yml#L12-L21

OCP 4.6 can support OpenShiftSDN and OVNKubernetes both.

https://docs.openshift.com/container-platform/4.6/installing/installing_vsphere/installing-vsphere-network-customizations.html#network-customization-config-yaml_installing-vsphere-network-customizations

mallmen commented 3 years ago

Added an option to group_vars/all.yml to specify the networkType. The install_config.yaml.j2 template will then use that value when specified, otherwise OpenShiftSDN is used. Only OpenShiftSDN and OVNKubernetes are valid values for install. Assert statement added to check for valid value on config.networkType when defined.