search

RedHatProductSecurity / cvss-v4-calculator

CVSS v4.0 calculator
https://redhatproductsecurity.github.io/cvss-v4-calculator/
BSD 2-Clause "Simplified" License
32 stars 22 forks source link

fix: consume and produce metrics only in the specified order #35

Closed pandatix closed 10 months ago

pandatix commented 10 months ago

This PR introduce a proposal to fix issues #24 #25 #34 in echo to our recent decision of strict metric ordering.

skontar commented 10 months ago

This looks really good. Can you please do a few small changes?

  1. Would you mind storing the vector loaded from another file in data? I do not remember if it has any advantages, but we store there all used constant data. That would make it more consistent.
  2. Can you name the order constant to be more descriptive? Maybe something like expectedMetricOrder?

Thanks!

pandatix commented 10 months ago

Sure, fixed it :)

skontar commented 10 months ago

Awesome. So the only issue I have is that I did not figure out how we can use the page deployment system to deploy a "stage". When I merge it and it will deploy a new version. Well ... 🤷.