Updates for CVSS v3.1 - Githubissues

RedHatProductSecurity / cvss

CVSS2/3/4 library with interactive calculator for Python 2 and Python 3

GNU Lesser General Public License v3.0

79 stars 28 forks source link

Updates for CVSS v3.1 #23

Closed skontar closed 5 years ago

bac commented 5 years ago

@skontar These changes look great and the tests are very thorough.

To see the changes in the test data I needed to first sort vectors_simple3 and vectors_simple31. You may want to sort those files and check them in.

Finally it was difficult to run the tests locally. If that is never the intention you may want to add that to the README.

Thank you for supporting 3.1 so quickly!

skontar commented 5 years ago

@bac I do not understand your comment about sorting the vectors_simple3 and vectors_simple31, can you explain? When I was comparing them I just replaced CVSS:3.1 with CVSS:3.0 in the later file and then used meld for compare.

Also, can you explain the difficulties with running tests? I am usually just running run_tests.sh on my Linux system where I have both Python 2 and Python 3 installed.

bac commented 5 years ago

When I first opened the test data files I wanted to see the differences between scores computed for 3.0 and 3.1. The files checked-in had data in different order, i.e. the first line were not for the same vector. So I sorted them to more easily compare. Not a big deal.
I didn't even see run_tests.sh. It works great. Perhaps a line in the README referencing it would be nice. I tried all of the usual suspects like just running pytest or python setup.py test and those didn't work.

skontar commented 5 years ago

I do not see it. For whatever reason I see them in the same order. Can you please double-check? Can you please let me know exact files and line numbers which you do not see matching?
OK, I will add it to the README.

bac commented 5 years ago

I retract my statement. I'm not sure what I thought I saw initially. Sorry for the noise.