search

RedHatProductSecurity / cvss

CVSS2/3/4 library with interactive calculator for Python 2 and Python 3
GNU Lesser General Public License v3.0
79 stars 28 forks source link

Update value name for Environmental v2 metric #24

Closed saigono closed 4 years ago

saigono commented 4 years ago

Change "Proof of Concept" to "Proof-of-Concept" in CVSSv2 Environmental metric, as in CVSSv2 guide https://www.first.org/cvss/v2/guide

saigono commented 4 years ago

Tagging @skontar, as I can't add you as a reviewer

skontar commented 4 years ago

I have noticed this. Interestingly the names were generated from the table from the specification, so it seems it has been updates sometimes later.

Anyway, quick grep revealed that some other parts of code are impacted. Interactive calculator also needs to be updated for sure and another impacted part is some of the utils. I am guessing those are not being used any more so it may be safe to remove.

saigono commented 4 years ago

Oh, grand, I'll update the code to reflect change in other places

saigono commented 4 years ago

Can't find anything else to update 🤷‍♂

skontar commented 4 years ago

Thank you. I will look into this pull request when I have a bit more time.

saigono commented 4 years ago

I found one more issue in Access Vector metric value so I'll re-check everything

skontar commented 4 years ago

Note: Original tables used for creation of constant files stored in https://github.com/skontar/cvss/blob/master/util/generate_constants.py seem to be removed in the v2 specification document.

saigono commented 4 years ago

Seems to be. However, I can't find anything else, or at least my code that uses your library doesn't fail on anything else