Closed saigono closed 4 years ago
Tagging @skontar, as I can't add you as a reviewer
I have noticed this. Interestingly the names were generated from the table from the specification, so it seems it has been updates sometimes later.
Anyway, quick grep revealed that some other parts of code are impacted. Interactive calculator also needs to be updated for sure and another impacted part is some of the utils. I am guessing those are not being used any more so it may be safe to remove.
Oh, grand, I'll update the code to reflect change in other places
Can't find anything else to update 🤷♂
Thank you. I will look into this pull request when I have a bit more time.
I found one more issue in Access Vector metric value so I'll re-check everything
Note: Original tables used for creation of constant files stored in https://github.com/skontar/cvss/blob/master/util/generate_constants.py seem to be removed in the v2 specification document.
Seems to be. However, I can't find anything else, or at least my code that uses your library doesn't fail on anything else
Change "Proof of Concept" to "Proof-of-Concept" in CVSSv2 Environmental metric, as in CVSSv2 guide https://www.first.org/cvss/v2/guide