search

RedHatProductSecurity / cvss

CVSS2/3/4 library with interactive calculator for Python 2 and Python 3
GNU Lesser General Public License v3.0
79 stars 28 forks source link

Update cvss3.py #35

Closed Roang-zero1 closed 2 years ago

Roang-zero1 commented 2 years ago

Fix reversed temporal and environmental severity in as_json() for cvss3

Fixes #34

skontar commented 2 years ago

Thank you for your contribution! Can you please also fix the typo in "environmental_everity"? Thank you!

Roang-zero1 commented 2 years ago

Didn't even notice that; fixed.

Roang-zero1 commented 2 years ago

Before you merge this let me add a new test scenario to prevent a regression at a later date.

I'll look into it tomorrow.

Roang-zero1 commented 2 years ago

Now that it's the correct commit the test is working. Should be good to go from my side

skontar commented 2 years ago

@Roang-zero1 Thanks for your contribution. Do you also need a pypi release?

Roang-zero1 commented 2 years ago

Yes that would be great as I am using it in a Dockerfile

Roang-zero1 commented 2 years ago

@skontar Is cloud you please check the release workflow, I see the commit but neither a tag nor a new release on pypi. Thanks!

skontar commented 2 years ago

@Roang-zero1 thanks for letting me know. Please check now.

Roang-zero1 commented 2 years ago

Thanks for checking, it's up now.