search

RedHatQE / katello.auto

Automated tests for katello
http://katello.org/
12 stars 15 forks source link

Fix: system details: save or cancel editing field #941

Closed sghai closed 11 years ago

kbidarkar commented 11 years ago

This looks to be a function which would be required by others and hence we require it in ui_common, I feel let's fix it in the common/save-cancel itself , the other name space it's being used in is tests/users.clj.

what do you think ?

kbidarkar commented 11 years ago

Ok, I just rechecked it also is being used in tests/distributors.clj

sghai commented 11 years ago

The fn common/inactive-edit-field is designed in a way that its accepts locator with :tag and for system tab the design of locators is bit changed. So I re-write this save-cancel function for system tests with name as save-cancel-details.

The fn save-cancel remains there in ui/common for other namespaces.

kbidarkar commented 11 years ago

I think as 90% of the code is the same, how about we send for what rec is being passed and loop it accordingly.

(instance? katello.System sys)

Let's merge it for now, may be we can enhance it later.

kbidarkar commented 11 years ago

ACK