RedHatQE / newa

New Errata Workflow Automation.
Apache License 2.0
0 stars 4 forks source link

Wait for TF request completion in the report step #76

Closed kkaarreell closed 2 weeks ago

kkaarreell commented 1 month ago

Wait for TF requests to completion when newa is issued only with the report step. This way we can re-run newa after the previous command has been terminated in the execute step for whatever reason.

kkaarreell commented 1 month ago

Hi @happz , I am sure there is things to improve in this PR and I would appreciate your review.

kkaarreell commented 2 weeks ago

I think I should revisit this approach. Waiting in report step assumes that all requests have been scheduled and are either running or finished. However, this may not be the case, due to the limit on the number of workers. It seems that better approach would be to introduction execute --continue which which won't schedule new requests if they have been already scheduled but schedule new requests if not.

kkaarreell commented 2 weeks ago

I think I should revisit this approach. Waiting in report step assumes that all requests have been scheduled and are either running or finished. However, this may not be the case, due to the limit on the number of workers. It seems that better approach would be to introduction execute --continue which which won't schedule new requests if they have been already scheduled but schedule new requests if not.

trying to implement this in https://github.com/RedHatQE/newa/pull/81