wait_for_firing_alert_sampler(..) to honor timeout

stesrn commented 7 months ago

Short description:

The method _monitoring.wait_for_firing_alertsampler() doesn't honor timeout, when the timeout value is a different custom value other than 10 minutes. Because of this behavior, few observability test cases that makes use of this method with custom timeout values like 15 mins fails as the method could only wait for maximum of 10 minutes

Now this issue is fixed by passing the custom timeout value to the other method that it calls.

More details:

Fixes a simple issue

What this PR does / why we need it:

Now the method passes the timeout value to the other method that it calls

Which issue(s) this PR fixes:

Special notes for reviewer:

Bug:

redhat-qe-bot commented 7 months ago

Report bugs in Issues

The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR. verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
- Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
- Cherry-pick will be started when PR is merged
To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge