Closed rarebreed closed 7 years ago
It also appears that when the runtime reflection code is used, it is not grabbing the parameter information. For example, take a look at this:
"rhsm.cli.tests.ActivationKeyTests.AttemptActivationKeyCreationWithBadNameData_Test" : {
"RHEL6" : {
"id" : "RHEL6-21788",
"parameters" : [ ]
},
"RedHatEnterpriseLinux7" : {
"id" : "RHEL7-51605",
"parameters" : [ "blockedByBug", "badName" ]
}
}
Somehow although for RedHatEnterpriseLinux7 it finds the param info, it doesn't for RHEL6
When I fixed this the first time, I only looked at the runtime reflection code, but the same issue occurs and deletes GUI tests when running lein compile.
I think, if I remove the call to the createMappingFile call in process(), the problem will be fixed. There technically should be no reason for that method call (which is super gnarly anyway).
I believe this one is fixed with the latest commit as we don't see the missing GUI test cases
I noticed that if I ran a lein compile, which generates mappings for the rhsm.cli.tests, and then followed that by running the runtime reflection code via:
Then the mapping.json file gets changed drastically. Need to review how the runtime reflection code is different. I tried to make the runtime code use as much as possible with the annotation/compile-time code (which is why a lot of the functions in TestDefinitionProcessor are static), but there are some differences