fix-issue-150 - Githubissues

RedHatQE / pylero

Python wrapper for the Polarion WSDL API

https://redhatqe.github.io/pylero/

MIT License

38 stars 25 forks source link

fix-issue-150 #151

Closed emesika closed 1 year ago

emesika commented 1 year ago

This patch fixes issue #150 changing work_item.py get_custom_fields method return code from : None to : cls._all_custom_fields, cls._required_fields

sleviim commented 1 year ago

Tracking this one, as it failed for me as well: [print(f.name) for f in tr.get_defined_custom_field_types(project_id="RHIVOS")] returns None None None None None None None None None None and print(tr._custom_fields) returns [] (tr refers to TestRun)

leelavg commented 1 year ago

fix looks legit as it is matching function doc comments (might be a crude stick to measure but it what it is)
in your listing @sleviim I see get_defined_custom_field_types but the fix is different, quick question is, does it hit this fix along the codepath?

sleviim commented 1 year ago

Thanks @leelavg, I was blinded by the issue and the errors and didn't notice it's not the same. I think my issue (retrieving None) refers to the f.name It seems that self._custom_fields in test_run.py#get_custom_field() is empty and wasn't initialized correctly. I'll file an issue for that

leelavg commented 1 year ago

Ack @sleviim, I got an internal ping around that issue, maybe you are from same team. Anyways, I'll take a look when you raise the issue.

sleviim commented 1 year ago

@leelavg done (issue 157) Luigi and I are working on the same product :)