Fix issues of jinja templating in include

RedHatQE / teflo

Teflo is a standalone orchestration software that controls the flow of a set of testing scenarios, allowing users to provision machines, deploy software, execute tests against them and manage generated artifacts and report results.

https://teflo.readthedocs.io/en/latest/

GNU General Public License v3.0

14 stars 16 forks source link

Fix issues of jinja templating in include #153

Closed JunqiZhang0 closed 3 years ago

JunqiZhang0 commented 3 years ago

1. Added toggle_jinja_include parameter under defaults section in
   teflo.cfg to enable the ability for teflo to handle the jinja templating in include section
2. Added unit tests
3. Added Documentation and example

JunqiZhang0 commented 3 years ago

@rujutashinde Yes

JunqiZhang0 commented 3 years ago

hi @jbpratt , I made this under a setting because we are not sure if this will cause regression. The default behavior didn't change. So if you don't set this variable, it will work exactly like before.

ryankwilliams commented 3 years ago

@JunqiZhang0 I give a +1 to what @jbpratt has mentioned. Why can't this just be default behavior? By default teflo supports jinja, so I personally I feel it should be supported by default for both standard SDF or included SDF. Over now needing to toggle on another flag in the config file. I would assume teflo would have tests to cover this functionality to ensure no new regressions would be introduced with this change?

dno-github commented 3 years ago

Hi @ryankwilliams` @jbpratt , so I had a discussion with teflo team, and we decided to have this well tested(with this feature as a default behavior), if it goes well and pass all the tests, we can make this as a default behavior.