RedHatQE / widgetastic.core

Making testing of UIs fantastic.
Other
36 stars 43 forks source link

Remove Unused Dependency: typing_extensions #245

Closed gdrosos closed 1 year ago

gdrosos commented 1 year ago

Summary

This pull request removes the unused dependency typing_extensions from the setup.cfg configuration file. The removal of this dependency is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The typing_extensions library was originally introduced to the project in #192 for its use in the src/widgetastic/types.py file. However, as of now, the said file (src/widgetastic/types.py) has been deleted, and the dependency appears to be unused within the source code, while it continues to be listed in the project's dependency files. Removing this unused dependency reduces the overall footprint of the application, mitigating potential security risks, and simplifying the dependency management process.

Changes

Impact

gdrosos commented 1 year ago

Hello @digitronik, @mshriver, @LightOfHeaven1994

I hope this message finds you all well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as maintainers would greatly contribute to our research efforts.

Could you please take a moment to review the changes proposed on this PR? Your input would be highly valuable to us.

Thank you for your consideration!

codecov[bot] commented 1 year ago

Codecov Report

Merging #245 (aa1d41e) into master (2c2843e) will not change coverage. The diff coverage is n/a.

:exclamation: Current head aa1d41e differs from pull request most recent head 886e6df. Consider uploading reports for the commit 886e6df to get more accurate results

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files          18       18           
  Lines        2570     2570           
=======================================
  Hits         2222     2222           
  Misses        348      348           
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.