search

RedHatQE / widgetastic.patternfly

Library of Patternfly widgets for Widgetastic.
Other
13 stars 29 forks source link

[RFR] Fix problem with locator in SettingsNavDropdown #120

Closed jarovo closed 4 years ago

jarovo commented 4 years ago

This requires https://github.com/RedHatQE/widgetastic.patternfly/pull/122 for tests to fully finish passing.

This pr mitigates the problem with repr discovered in CFME integration_tests and adding tests for such problems for all the widgets in widgetastic.patternfly.

Note this PR adds a test of stringification of (mostly) all the components defined in the widgetastic_patternfly. Perhaps it would be good to come-up with a way to put the tooling for this to Widgetastic itself and let all the descendant projects benefit from it somehow.

Fixes: https://github.com/ManageIQ/integration_tests/issues/10191

coveralls commented 4 years ago

Coverage Status

Coverage increased (+3.006%) to 55.912% when pulling b5ca7ae731059e20872c25813979acb52677e0eb on jaryn:fix_log_issues into 5110170b6c7f52b30f7d1920e31cb559d58b4b65 on RedHatQE:master.

mshriver commented 4 years ago

Travis unit tests passing, but no check is getting reported to GitHub.