search

RedHatQE / widgetastic.patternfly

Library of Patternfly widgets for Widgetastic.
Other
13 stars 29 forks source link

Error handling flash dismiss #124

Closed mshriver closed 4 years ago

mshriver commented 4 years ago

On some applications, flash messages may dismiss themselves between WT creating the FlashMessage instance, and trying to delete it

This defaults the dismiss method to log and squash NoSuchElement and StaleElementReference exceptions.

Includes unit tests

devendra104 commented 4 years ago

I have tested the settings UI test cases with this change and it works

pytest tests/foreman/ui/test_settings.py 
=============================================================================================== test session starts ===============================================================================================

tests/foreman/ui/test_settings.py .........ss.sss.                                                                                                                                                          [100%]

============================================================================= 11 passed, 5 skipped, 22 warnings in 800.05s (0:13:20) ==============================================================================
mshriver commented 4 years ago

Thanks @devendra104 - some unrelated unit test failures in travis that I'd like to get fixed too.

mshriver commented 4 years ago

Looked into the datepicker failure, wrote an issue instead of trying to include that fix here: https://github.com/RedHatQE/widgetastic.patternfly/issues/125

mshriver commented 4 years ago

Looked into the modal failure, wrote an issue instead of trying to include the fix here: https://github.com/RedHatQE/widgetastic.patternfly/issues/126