RedHatQuickCourses / rhods-intro

Introduction to Red Hat OpenShift AI (RHOAI)
https://redhatquickcourses.github.io/rhods-intro/
13 stars 14 forks source link

Mention version of RHOAI for lab testing #41

Closed rsriniva closed 8 months ago

rsriniva commented 9 months ago

@jramcast - test for PR from fork. looks like the source repo checks in the GH actions work as suggested by you. This PR is to mention the version of RHOAI we tested with in the home page.

jramcast commented 9 months ago

Consider rendering the HTML even if the PR comes from a fork, as a way to perform basic testing. What we want to block is the publishing step. Something like this maybe?

    steps:
      - name: Checkout repository
        uses: actions/checkout@v2

      - name: Install Node.js
        uses: actions/setup-node@v2
        with:
          node-version: '16'

      - name: Install Antora
        run: npm ci

      - name: Generate Site
        run: npm run build

      - name: Publish PR preview to GitHub Pages
        if: ${{ ! github.event.pull_request.head.repo.fork }}
        uses: rossjrw/pr-preview-action@v1
        with:
          source-dir: ./build/site
jramcast commented 9 months ago

UPDATE: @rsriniva please see https://github.com/RedHatQuickCourses/rhods-model/issues/7, I have applied the fork condition at the step level so only the publish step is ignored.

rsriniva commented 9 months ago

excellent suggestion @jramcast! I approved your changes and test PRs

rsriniva commented 9 months ago

applied your if: block suggestion to this repo. thanks!