Open Rocco83 opened 7 years ago
Hi,
given the code, if the latest job is found with "no new packages" is found, then if checkrepos is "on" all of the tasks are parsed up to find out a task that match the channel that we need for. We are here at the code https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L386
When one repository is found, further check are done https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L413
A deeper check start https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L200
When the task is from the past, the code is just skipping this task https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L205
Wondering if in this section of code, if the task is from the paste, we can skip the remaining tasks. https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L415
Looking at the code , my understanding is that if a "past task" is found, since the tasks are sorted by ended_at, we can be sure that no other tasks will be found afterwards with packages that are missing.
Any comment?
Hi,
given the code, if the latest job is found with "no new packages" is found, then if checkrepos is "on" all of the tasks are parsed up to find out a task that match the channel that we need for. We are here at the code https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L386
When one repository is found, further check are done https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L413
A deeper check start https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L200
When the task is from the past, the code is just skipping this task https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L205
Wondering if in this section of code, if the task is from the paste, we can skip the remaining tasks. https://github.com/RedHatSatellite/katello-cvmanager/blob/64778cff97c5bb023816624787cd920f5759acea/cvmanager#L415
Looking at the code , my understanding is that if a "past task" is found, since the tasks are sorted by ended_at, we can be sure that no other tasks will be found afterwards with packages that are missing.
Any comment?