RedHatSatellite / katello-cvmanager

manage Katello content views
GNU General Public License v2.0
49 stars 31 forks source link

Use only labels in cvmanager.yaml #50

Closed fm0l closed 6 years ago

fm0l commented 6 years ago

Make cvmanager use only labels, since at the moment the CCV uses the label while the definitions of other actions use names. This is confusing for who implements cvmanager and whoever needs to mantain it, and also the name of the CV / CCV could be changed by a Satellite administrator, while the LABEL is permanent. This could prevent blocking unknowingly the automation when changing an object name.

peppos commented 6 years ago

@fm0l your commit fix https://github.com/RedHatSatellite/katello-cvmanager/issues/26 ? if yes +1 for label like https://github.com/RedHatSatellite/katello-cvmanager/issues/23

fm0l commented 6 years ago

@peppos yes basically. This is just a change from name to label, if we want to keep the compatibility we can always think about adding an option too choose between name and label with default set to label