Initial code from oasis

RedHatSatellite / satellite-ansible-compilation

Repository for Satellite Ansible roles built using foreman-ansible-modules

GNU General Public License v3.0

17 stars 19 forks source link

Initial code from oasis #11

Closed cojmckee closed 4 years ago

evgeni commented 4 years ago

please don't commit binaries (roles/install/files/python2-apypie-0.2.1-2.el7.noarch.rpm)

evgeni commented 4 years ago

So a two thoughts:

this contains a jenkins config -- can we split that out in a separate PR, merge that and let Jenkins at least run lint on the PR?
I'm fine merging this, even if it does not comply with our self-imposed rules, but I think the binary file should go, and the import_tasks should use the right filename (accidental find, but that's why I'm asking about the linting in the above point)

ehelms commented 4 years ago

As people comment and review, I want to remind that the general idea we had was to bring in these large contributions and then make adjustments. There is balance to strike with reviewing and @cojmckee making changes with filing Github issues to address later. I'll leave a large part of that decision up to @cojmckee on how much he wants to handle reviews here vs follow up.

kedark3 commented 4 years ago

I agree with @ehelms on his assertion between review and follow up.