search

RedHatSatellite / satellite-ansible-compilation

Repository for Satellite Ansible roles built using foreman-ansible-modules
GNU General Public License v3.0
17 stars 19 forks source link

Rule Loosening (Atleast Initially) #7

Closed jjaswanson4 closed 3 years ago

jjaswanson4 commented 4 years ago

"The roles shall not use hammer via command/shell or the uri module to talk to the API directly." "The roles should not duplicate functionality of other existing roles in the same repository."

I don't disagree with this in theory, but I'm not sure we can put a hard ban on these this early. Since the modules aren't GA (and don't cover all functionality, like adding capsules, running the satellite installer, etc) I think we have to allow this as long as there is intention/work to re-code with the modules. "Technically speaking", we do fully support hammer and using the API so supportability isn't affected by leveraging them.

Thoughts?

sthirugn commented 4 years ago

If there is a genuine reason for using the methods described in the quoted text, then I think it should be allowed.

aoyawale commented 4 years ago

I think like we discussed during our meeting that for those cases using those modules is fine as we are starting out. Since those modules are not ready or not there yet.

bherrin3 commented 3 years ago

The README.md has been updated to allow this to be more of a compilation and non-official source for information. Also, the originally quoted text is no longer present.

Closing, as I believe the intent of this compilation will be more open, as long as bare-minimum requirements and linting are met.