Fixed hammer-setup required for foreman-maintain

[ntkathole]

Fixes #353

[johnpmitsch]

thanks for the PR, I'll test soon :)

[johnpmitsch]

yee-haw

[johnpmitsch]

will this just append to existing /etc/foreman-maintain/foreman-maintain-hammer.yml files? For example, if I have:

:foreman:
  :username: admin
  :password: kittens123

will the lineinfile match this? It seems like it won't and will just append new credentials to the file (this may work, but it is a bit messy if we append to the file and don't erase existing creds in it)

Since we always change the Satellite credentials to admin/changeme, I wonder if this would work better:

• move /etc/foreman-maintain/foreman-maintain-hammer.yml to /etc/foreman-maintain/foreman-maintain-hammer.yml.satclone.backup if it exists
• copy over a foreman-maintain-hammer.yml file containing admin/changeme config to /etc/foreman-maintain

[johnpmitsch]

Also, another question - Were there changes in foreman-maintain to no longer need the credentials? I remember the fact that foreman-maintain needed credentials for a service restart was a concern when we initially discussed this issue.

[johnpmitsch]

@ntkathole I didn't see you updated this! I can review soon.

Do you know an answer to this question?

Also, another question - Were there changes in foreman-maintain to no longer need the credentials? I remember the fact that foreman-maintain needed credentials for a service restart was a concern when we initially discussed this issue.

[ntkathole]

@johnpmitsch the changes in f-m is in development. I see PR https://github.com/theforeman/foreman_maintain/pull/261 open to fix it.

[johnpmitsch]

PLAY RECAP *********************************************************************
192.168.121.25             : ok=21   changed=16   unreachable=0    failed=0   
192.168.121.37             : ok=21   changed=16   unreachable=0    failed=0   
192.168.121.75             : ok=21   changed=16   unreachable=0    failed=0   
192.168.121.76             : ok=21   changed=16   unreachable=0    failed=0 

passed automation, thanks @ntkathole!