RedHatSatellite / satellite-clone

Utility to assist cloning an existing Satellite 6 server to a new host
GNU General Public License v3.0
37 stars 31 forks source link

Remove support for 6.4 and earlier and don't require candlepin password #381

Closed johnpmitsch closed 3 years ago

johnpmitsch commented 3 years ago

The cpdb update step is handled by the installer and is cached in a file now. The step was a workaround so we can remove it, which will fix the blank cp pw in answers file issue.

This commit also removes 6.4 and earlier support, updates docs, and removes misc no-longer-relevant items like cacheable facts.

johnpmitsch commented 3 years ago

This passed 6.8 and 6.7 tests:

192.168.121.21             : ok=21   changed=16   unreachable=0    failed=0    skipped=3    rescued=0    ignored=0   
192.168.121.92             : ok=21   changed=16   unreachable=0    failed=0    skipped=3    rescued=0    ignored=0   
192.168.121.93             : ok=21   changed=16   unreachable=0    failed=0    skipped=3    rescued=0    ignored=0   
192.168.121.99             : ok=21   changed=16   unreachable=0    failed=0    skipped=3    rescued=0    ignored=0   
johnpmitsch commented 3 years ago

Working on a 6.6 offline backup as well

TASK [satellite-clone : debug] *************************************************************************************************************************************************
Tuesday 05 January 2021  16:05:22 +0000 (0:00:00.319)       0:46:28.354 ******* 
ok: [localhost] => {
    "msg": "****NOTE**** Your Satellite's hostname is updated to match the original Satellite ****NOTE**** Your Satellite's password is updated to changeme"
}

msg: ****NOTE**** Your Satellite's hostname is updated to match the original Satellite ****NOTE**** Your Satellite's password is updated to changeme

PLAY RECAP *********************************************************************************************************************************************************************
localhost                  : ok=72   changed=27   unreachable=0    failed=0   
sthirugn commented 3 years ago

Great PR! For the future, if you can split different unrelated sub-items as different commits, it will be easy for the reviewers and will be very useful for future debugging.

johnpmitsch commented 3 years ago

Great PR! For the future, if you can split different unrelated sub-items as different commits, it will be easy for the reviewers and will be very useful for future debugging.

Sure thing, would you like more time to review or good to merge based on @chris1984's ack?

johnpmitsch commented 3 years ago

@sthirugn updated according to your comment and I also changed all the docs to use satellite-maintain, I noticed it switched between satellite-maintain and foreman-maintain. (all in separate commit)

sthirugn commented 3 years ago

@johnpmitsch looks great, thanks!