search

RedHatSatellite / satellite-clone

Utility to assist cloning an existing Satellite 6 server to a new host
GNU General Public License v3.0
37 stars 31 forks source link

Always use katello:reimport rake, never katello:reindex #393

Closed wbclark closed 2 years ago

wbclark commented 2 years ago

foreman-rake katello:reindex was previously replaced with foreman-rake katello:reimport. Currently supported versions use reimport only, so variables tracking which command must be used are dropped. The variable previously named run_katello_reindex is also renamed to be accurate to the currently supported Satellite versions.

sthirugn commented 2 years ago

/lgtm

evgeni commented 2 years ago

I've dropped roles/satellite-clone/vars/satellite_6.5.yml over in #391, mind rebasing? :)

wbclark commented 2 years ago

I've dropped roles/satellite-clone/vars/satellite_6.5.yml over in #391, mind rebasing? :)

Sure thing, thanks

evgeni commented 2 years ago

Absolutely happy with the change. The only thing I wonder about is the backwards compatibility, which we're breaking by renaming that variable.

Personally, I am happy to break, as I expect users to re-visit their config anyways, as they are also cloning a new version of Satellite, but you never know ;)

ehelms commented 2 years ago

I suppose also, this depends on which version of Satellite this change goes into? In 7.0, the target is to have a version specific maintenance repository so if this went only in there we would not break 6.Y.

ekohl commented 2 years ago

I think this is safe to do. 6.5 (and older) cloning has been unsupported anyway and actively removed. It now does have a merge conflict though.

ehelms commented 2 years ago

@wbclark this needs a rebase