search

RedHatSatellite / satellite-clone

Utility to assist cloning an existing Satellite 6 server to a new host
GNU General Public License v3.0
37 stars 31 forks source link

Capsule 6.10 support #401

Closed evgeni closed 2 years ago

evgeni commented 2 years ago

The original "partial Satellite 6.10 support" change was missing support for disassociating external capsules. This change adds support for those, by checking for the "Container_Gateway" feature, as the "Pulp Node" feature is gone with Pulp3 and there is (currently) no better way to identify an external capsule -- all of them have the Pulpcore feature.

to recap the problem:

I've opened https://projects.theforeman.org/issues/33610 to track inclusion of those fields into the proxy search. And https://projects.theforeman.org/issues/33611 to track the exposure of those fields in the API response.

evgeni commented 2 years ago

@ekohl one thought that I had: we can "work around" the issue for now by searching for proxies that have the Pulpcore and the Container_Gateway features, as I think CG is only ever enabled on external proxies?

ekohl commented 2 years ago

That sounds like a less ugly workaround than hostname. I'd :+1: that. I also think that for all Satellite versions this would be true. So it'd be Pulp Node or (Pulpcore and CG).

evgeni commented 2 years ago

technically, we don't even need to look for Pulpcore, as that will be true for all Satellite deployments anyways.

ekohl commented 2 years ago

While that's true today, I'd still prefer to have it in. There's been talk about REX-only Capsules and it'd be great if we one day could support that.

evgeni commented 2 years ago

While that's true today, I'd still prefer to have it in. There's been talk about REX-only Capsules and it'd be great if we one day could support that.

okay, what's the correct HAVING SQL statement is for that? ;-)

PS: REX only capsules won't have the CG feature either ;)

evgeni commented 2 years ago

rebased after #394 got merged. I am not too inclined finding out what the right SQL invocation is for checking both features.