search

RedHatter / Graveyard

A plugin for the Hearthstone Deck Tracker that displays minions that have died.
41 stars 21 forks source link

Tess Greymane and Settings Update #46

Closed Supergecki closed 5 years ago

Supergecki commented 5 years ago

The following changes have been made:

The following issues have been solved (and therefore can be closed):

That's it! Comment if there are any issues! PS: Could anyone please test the Tess view? I don't own this card so I can't do it myself. I just want to know it works. Thanks!

chWolfgang commented 5 years ago

This is fantastic work. TYVM. Could you post a link to the file again? Also, I can test Graymane for your -- and anything else you want. Blizzard friend info NA region, Wolfgang (and the number) 1572

Supergecki commented 5 years ago

Here comes the new version: Graveyard.zip. Thanks for testing Greymane!

chWolfgang commented 5 years ago

Unfortunately, Tess does not seem to be working. I get no listing of spells from other classes I have cast. However, I get no errors. I did this over a few games in practice mode and standard.

Also, another popular card you may want to add is the Paladin card "Kangor's Endless Army". It is a 7 mana legendary that resurrects 3 friendly mechs.

Please let me know any specific test you would like done or what I could do to help.

Supergecki commented 5 years ago

Maybe this one? Graveyard.zip I hope it works now. Thanks for testing!

chWolfgang commented 5 years ago

Sadly, I got the same results. No error, rest of if seems to be working (did not test all features). But still not tracking cards from other classes (spells nor creatures.). Happy to keep testing.

Supergecki commented 5 years ago

Found the bug, now it should work. Graveyard.zip Thanks for testing (still)!

chWolfgang commented 5 years ago

Still not getting it... :( Just and FYI, I simply copied the new dll over the old dll in the Plugins directory. Making sure there was only one copy. I deleted the the one you put out before with the different name. I did not delete my old settings file. Not sure if that is going to matter? Looking forward to the next file.. :)

Supergecki commented 5 years ago

Keeping the old settings file shouldn't matter as long as the Graveyard plugin itself and the Tess Greymane view is turned on. Another try (I hope this works now): Graveyard.zip

chWolfgang commented 5 years ago

So, it is working with creatures from other classes but not with spells. Confirmed over a couple games. Both with creatures first and second (and spells after).

Supergecki commented 5 years ago

Now it should work... (I hope) Graveyard.zip Btw, do you own Dragoncaller Alanna or Shudderwock? They could be tested too. Thanks!

chWolfgang commented 5 years ago

IT WORKS!! (happy dance) I can test those other two as well. However, I am not sure how much I can do today (busy day). Monday I will have more time. If I do get a chance today, I will let you know.

Also, please remember to consider "Kangor's Endless Army". It would mean adding testing for MECH, so I am not sure how much work that is.

Supergecki commented 5 years ago

That's great news! (happy dance too) Take your time for testing them (especially Shudderwock in combination with non-minion battlecries, such as Hagatha the Witch). I'll see when I have time to implement Kangor's Army (but it wouldn't be that much work). The real problem I see is that Kangor's Endless Army focuses on the magnetic upgrades of your mechs, and they can't be displayed in the graveyard. Would you find it important to add it anyway? Let me know!

This update is fully tested now. Branches can be merged.

chWolfgang commented 5 years ago

Dragoncaller Allan seems to work well. Did not show <5 mana spells. Did show 5 and > spells. Worked w/ and w/o Alanna in hand. Worked on 5 mana spell discounted to 4. (I got a couple really good draws for this :).

I believe I have a shudderwock deck in HSDT that I can load up. Should be able to test that pretty quick as well.

Thanks again for all this. This is going to push this add-on over the top :)

chWolfgang commented 5 years ago

Okay, one quick game with Sudderwock looked good. It only chose BATTLECRY minions, even if the Battlecry didn't do anything on play (Mind Control Tech). It did not show non-battlecry minions. Looking good!

edited for typo

chWolfgang commented 5 years ago

RE: Kangor's Actually, I would find it useful. Generally, I just need to know how many base mech's I have played. This lets me know if I will get an "upgrade" back. -- If I have only 2 dead mechs, I can upgrade one on board, sacrifice it before Kangor and get it back. Otherwise, I may want to wait on the upgrade. So I find myself look through the whole killed list counting mechs. Or, what are the chances of getting a certain mech back (3 out of 5) kind of thing.

But, I may just suck w/ that deck :)

Supergecki commented 5 years ago

Okay, I will see what I can do. Btw, I made a list of cards since Un'Goro that could be added: Cards to be added.txt I could implement some of those cards to use existing views (e.g. 'Da Undatakah' to use the view of Nine Lives). Maybe (when I have some spare time) I will add them. Thanks for testing everything!

chWolfgang commented 5 years ago

Looking over the list, I think it is good. I am not sure Lynessa would be helpful. But if you are going to track spells cast on a specific minion, there is also Primalfin Champion (Paladin) and Test Subject (Priest) that return spells cast on minion to hand. BUT, these are not unique so might be to hard to track. This may be a rabbit hole.

Zul'jin would be handy and since you have a mechanic for tracking spells cast it should be easy.

Also, just a thought for future maintenance, you may want to just make selections for tracking card types/tribes (Murloc, Deathrattle, Mech, Battlecray, Other Class Cards, etc) in the options. Then put cards in as triggers. IE

DEATHRATTLE When a deck contains Witching Hour, Da Undatakah, Twilight's Call, Tomb Lurker,.. show friendly Deathrattle minions that died this game.
Enabled [SWITCH]

Of course, you would still need some special like Spells > 5 mana, Cards Discarded, etc.

This would also make the Settings Menu a little less daunting. Just my 3.5 cents :)

Sorry for rambling. Let me know what I can do to help, or if you need me to clarify anything.

Supergecki commented 5 years ago

I already thought that implementing Lynessa would be really hard (because you would have to track the target the spell was cast on). Zul'jin shouldn't be a big thing.

Creating some view categories (e.g. Deathrattle) was already my idea. There's just one problem with Tomb Lurker: Tomb Lurker is also able to revive enemy deathrattle minions (not like, for example, Da Undatakah, Twilight's Call or Nine Lives). It would need a different kind of view.

Btw, I already looked over the expansions and adventures before Un'Goro. Doesn't seem like there is anything that would make sense to add.

Thanks for checking the list!

chWolfgang commented 5 years ago

Also, I am still willing to test anything. I have a mostly complete collection.

Supergecki commented 5 years ago

Is still somebody after this? The branches weren't merged yet. Would be cool if someone could do this!

chWolfgang commented 5 years ago

Hi, Just wondering if you are playing SoU? Also, did you get a chance to add any of the other types? Some nice new Resurrection cards. Even a nuetural one.

Also, I hope this can be merged into the main to get some viability. It is a great update to a great Add-on.

Thanks for all your help/work.

Supergecki commented 5 years ago

Hello there, yes, I'm already playing (and enjoying) SoU. These new cards should be Psychopomp (Priest) and Body Wrapper (Neutral), right?

Actually, I wanted this to be merged into the main before I started working on other cards. Now it's been some weeks since I uploaded my branch... Let's see when the pull request is accepted.

Anyway, you're welcome. I really enjoy working on this project and refining my programming skills a bit.

I'll see when I have time to add some cards. Here's btw an updated list of the cards we wanted to add.

Then, have fun in Uldum!

chWolfgang commented 5 years ago

Glad you are enjoying SoU. I think it is one of the best, if not the best, expac. Love that their is so much to try.

I fully understand you not wanting to put more effort into this until it gets accepted. I hope it does soon.

The list of card seems correct to me. I use most of those cards.

Thanks for getting back to me so quick. Good hunting!!!!!

cats4gold commented 5 years ago

I was just about to start working on adding Tess to this plugin, I'm glad to see someone's already done it. I hope it gets merged soon!

RedHatter commented 5 years ago

Thank you for all the hard work!