search

RedHeadphone / react-json-grid

🔄 Effortlessly transform complex nested JSON into grid tables
https://npmjs.com/package/@redheadphone/react-json-grid
MIT License
18 stars 4 forks source link

Having a value as null / undefined breaks the component #16

Closed essuraj closed 3 months ago

essuraj commented 3 months ago

instead of .toString(). use String(null)

RedHeadphone commented 3 months ago

Can you give more context and exact props that break the component? Also if you know the fix you are open to creating PR for the fix.

essuraj commented 3 months ago

any props variety has this issue, eg: https://codesandbox.io/s/react-json-grid-demo-7ymdg3

image image
RedHeadphone commented 3 months ago

Oh yeah, I don't know how I missed it. Using String(value) instead of value.toString() is definitely better. Thanks for letting me know.

would you like to fix it?

also on a sidenote which tool are you using to highlight in the screenshot?

essuraj commented 3 months ago

https://shottr.cc/ Regards, Suraj ES

On Tue, Jul 23, 2024 at 9:46 PM Huzaifa Khilawala @.***> wrote:

Oh yeah, I don't know how I missed it. Using String(value) instead of value.toString() is definitely better. Thanks for letting me know.

would you like to fix it?

also on a sidenote which tool are you using to highlight in the screenshot?

— Reply to this email directly, view it on GitHub https://github.com/RedHeadphone/react-json-grid/issues/16#issuecomment-2245670579, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANIHELW62I7L2UEGPXXQXTZNZ6UPAVCNFSM6AAAAABLHZMUIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGY3TANJXHE . You are receiving this because you authored the thread.Message ID: @.***>