search

RedHenLab / RapidAnnotator-2.0

With Red Hen Lab’s Rapid Annotator we try to enable researchers worldwide to annotate large chunks of data in a very short period of time with least effort possible and try to get started with minimal training.
GNU General Public License v2.0
14 stars 19 forks source link

Fixed adding/removing annotators bug #48

Closed rrrokhtar closed 3 years ago

rrrokhtar commented 3 years ago

Description

This pull requests solves this issue Unexpected behavior when adding or removing annotators at an experiment #47 It is a simple solution as I found the location reloading in unnecessary and making the unexpected behavior because immediate reloading makes the code in an inconsistent state and I didn't get what is their purpose so commenting them fixed that issue.

Screenshots

1. Firefox is working right now

Firefox fixed bug

2. Making quick adding is working correctly as well as removing, everything is fine. (this on Google Chrome)

Unexpected behavior on adding annotators

peteruhrig commented 3 years ago

I'd like to wait for @gulshan-mittal's input here. I think there was a reason for the reload. Did you check whether in your fixed version everything is updated in the interface when you use Google Chrome?

rrrokhtar commented 3 years ago

Yeah I recommend waiting @gulshan-mittal 's comment right there. And yes the second screenshot is taken from Google Chrome

gulshan-mittal commented 3 years ago

@rrrokhtar This is an issue of progress graph updating dynamically. Just find a solution to update the graph dynamically, then we don't need a reload functionality.

rrrokhtar commented 3 years ago

Hey @peteruhrig and @gulshan-mittal . I have fixed up the plot updates without reloading as we discussed I have attached the new plot with the response of the adding/removing request Kindly review that @gulshan-mittal Here is a screenshot describes that FixedPlotUpdate