RedJocker / fix-PhotoEditor

0 stars 0 forks source link

stage5 update description and confirm correctness of proposed solution #10

Closed RedJocker closed 2 years ago

RedJocker commented 2 years ago

there are two things not clear that can lead to miss-calculations. One is if rgbAverage should be calculated pixel by pixel or for the whole image (proposed solution adopts pixel by pixel) Second if rgbAverage (which is used to on saturation filter) should be calculated before applying any filter or after brightness and contrast filter since it is required for those filters to be applied before saturation filter (proposed solution adopts before)

Also verify correctness of proposed solution on second item

RedJocker commented 2 years ago

test and description updated on fixTests branch

Todo: update proposed solution

RedJocker commented 2 years ago

new proposed solution is on alternativeSolution branch