RedJocker / fix-PhotoEditor

0 stars 0 forks source link

revising code #6

Closed RedJocker closed 2 years ago

RedJocker commented 2 years ago

hi, I was assigned to review the code for the project, so I forked the repository and opened an issues page with some things I have already found and some that I think that can lead to problems and assigned myself to fix these issues. Maybe you can be interested in commenting on those there. I've been assigned due to concerns with stage6, but currently I am more worried with stage3. Stage3 expects writing to storage and that requires acquiring permissions from app user or the program crashes. Current proposed solution does not have that question solved, which should not be that hard to update (https://www.youtube.com/watch?v=S4jkcRhembY). But tests should probably also be updated to give permissions when requested and also to check if solutions are correct in this permission requirement. This might need some investigation on how to achieve that.