search

RedJue / git-commit-plugin

Automatically generate git commit
https://marketplace.visualstudio.com/items?itemName=redjue.git-commit-plugin
MIT License
189 stars 49 forks source link

<Subject> : no more than 20 words #72

Closed ArthurMynl closed 1 year ago

ArthurMynl commented 2 years ago

when creating a commit, the wizard says :

: no more than 20 words But in reality, it's no more than 20 characters. Should just change the wizard spelling
RedJue commented 1 year ago

when creating a commit, the wizard says : : no more than 20 words

But in reality, it's no more than 20 characters.

Should just change the wizard spelling What did you spell?

ArthurMynl commented 1 year ago
Capture d’écran 2022-09-19 à 11 16 13

for example here, my text is 21 characters, and so it can't be validated whether it's not more than 20 words, but more than 20 characters

RedJue commented 1 year ago
Capture d’écran 2022-09-19 à 11 16 13

for example here, my text is 21 characters, and so it can't be validated whether it's not more than 20 words, but more than 20 characters

You're right! it's my mistake, in code it's no more than 21 characters, to fixed it, you can follow here, set GitCommitPlugin.MaxSubjectWords limit as you like.

ArthurMynl commented 1 year ago

I have corrected the bug and created a pull request