RedMadRobot / figma-export

Command line utility to export colors, typography, icons and images from Figma to Xcode / Android Studio project
MIT License
730 stars 114 forks source link

Name is optional in xcodeproj, so compare the path instead #125

Closed ptxmac closed 2 years ago

ptxmac commented 2 years ago

the group.file command only looks for file references by name, but there's no guarantee that a reference actually has a name. (changing target membership seems to clear the name)

subdan commented 2 years ago

Thanks for the PR. I will review it on weekend.

ptxmac commented 2 years ago

How did you find this bug? How can I reproduce it? Can you write test that catches this bug?

I discovered it because I added the Color+extension.swift to a 2nd target. When doing that it appears XCode removes the name key