search

RedMadRobot / figma-export

Command line utility to export colors, typography, icons and images from Figma to Xcode / Android Studio project
MIT License
718 stars 114 forks source link

Support high contrast colors #157

Closed alexey1312 closed 2 years ago

alexey1312 commented 2 years ago

Solution for this issue

alexey1312 commented 2 years ago

1 - Fix typo hight → high ✅ 2 - Fix issue I point in the comment about dark appearance. ✅ 3 - Add unit tests for XcodeColorExporter which checks exporting high contrast colors for useSingleFile is true and false. It seems that testing useSingleFile in XcodeColorExporter is not very correct, since different areas of responsibility. I think we need to write tests on the ColorLoader, but for this it needs to be refactored. I checked in Playgrounds, the filter for useSingleFile works correctly. ✅ 4 - I tried to run FigmaExport for Example project and it fails to export with the following error: Bad asset name.... You must fix this issue. ✅

subdan commented 2 years ago

Thanks for the PR, @alexey1312! I've published a new version of FigmaExport with this feature.

alexey1312 commented 2 years ago

Thanks for the code review, @subdan ! 🙏