RedMadRobot / figma-export

Command line utility to export colors, typography, icons and images from Figma to Xcode / Android Studio project
MIT License
718 stars 114 forks source link

Tests are failing on Contents.json output #225

Closed hadiidbouk closed 5 months ago

hadiidbouk commented 7 months ago

Hey

There are two failing tests: testExport_preservesVectorRepresentation & testExport_preservesVectorRepresentation2

It seems it's related to the generated Contents.json file where the properties aren't sorted correctly.

image

subdan commented 7 months ago

It's weird. The tests pass without any failures on CI and my Mac.

subdan commented 7 months ago

Which version of Xcode are you using?

sanghoonkim1 commented 6 months ago

I meet same problem. I am using xcode 15.0. The order of properties changes every time I export.

KulakovaE commented 5 months ago

I meet same problem. I am using xcode 15.0. The order of properties changes every time I export.

Same here.

subdan commented 5 months ago

Thanks for report. The issue has been fixed.

mbruegmann commented 5 months ago

Can you provide a new release including this fix?

subdan commented 5 months ago

@mbruegmann, done https://github.com/RedMadRobot/figma-export/releases/tag/0.37.4

mbruegmann commented 4 months ago

@subdan Awesome, thank you!

mbruegmann commented 4 months ago

@subdan Somehow the changes are not in the release. They are also not visible on the master branch: https://github.com/RedMadRobot/figma-export/blob/master/Sources/XcodeExport/Model/XcodeExportExtensions.swift https://github.com/RedMadRobot/figma-export/blob/master/Sources/XcodeExport/XcodeColorExporter.swift

Was it made on a fork on another repository? (see hint) https://github.com/RedMadRobot/figma-export/blob/cea5b1f414a1b6dea76fe883aba709bcbf6d7499/Sources/XcodeExport/Model/XcodeExportExtensions.swift

Could you take a look? 🙏

subdan commented 4 months ago

@mbruegmann, oops, sorry. GitHub says that the branch with the fix merged into master but it is not. I've fixed it and make a new release. Please check.

mbruegmann commented 4 months ago

Works perfectly now! 🚀 Thanks @subdan !