RedMadRobot / figma-export

Command line utility to export colors, typography, icons and images from Figma to Xcode / Android Studio project
MIT License
726 stars 114 forks source link

Feature/support other devices idiom #37

Closed yyjim closed 3 years ago

yyjim commented 3 years ago

Description

Support export image with ~idiom suffix for #36

Changes

yyjim commented 3 years ago

I added scale property to Image, so I'm thinking if ImagePack still need these singleScale, individualScales cases.

subdan commented 3 years ago

I will do code review on the weekend.

subdan commented 3 years ago

What do you want to use idioms for? You can export illustration as PDF file and stretch it on iPadOS.

yyjim commented 3 years ago

We want to use idiom suffix to export different images with same asset name. I'll provide an example.

All issues are solved, please review it again.

Thanks

subdan commented 3 years ago

One more thing... Could you please add information about idioms to the README? Design requirements / For figma-export images

lichin-lin commented 3 years ago

@subdan I've add explanation for the idiom usage, please help check if there's anything still not clear :)

lichin-lin commented 3 years ago

Just update it, please check them again, thanks!

lichin-lin commented 3 years ago

fixed them 👍