RedMadRobot / figma-export

Command line utility to export colors, typography, icons and images from Figma to Xcode / Android Studio project
MIT License
726 stars 114 forks source link

[Feature] support idiom for icon #39

Closed yyjim closed 3 years ago

yyjim commented 3 years ago

Description

Support export icons with ~idiom suffix.

This PR include change in #38

Changes

subdan commented 3 years ago

This PR breaks color and icon exporting.

  1. When I try to export ic/24/profile~ipad icon, FigmaExport terminates with the following error: Error: Bad asset name «ic_24_profile~ipad»

  2. When I try to export colors to Xcode, FigmaExport terminates with the following error: error: Unable to add some file references to Xcode project

subdan commented 3 years ago

Sorry, I've checked wrong branch.

subdan commented 3 years ago

Return "@" symbol when exporting images to Xcode project.

image
subdan commented 3 years ago

I've run figma-export images for iOS example project and the result is wrong.

image

Look at the exclamation marks.

yyjim commented 3 years ago

ok, Thanks for review it. I'll resolve the conflicts and fix the issue soon.

yyjim commented 3 years ago

Hi @subdan The issues are resolved, please review it when you have time. Thanks.

subdan commented 3 years ago

Thanks. I will make review tomorrow.

yyjim commented 3 years ago

Hi @subdan Please check the last commit for updating the TemplateProperties.

subdan commented 3 years ago

Thanks for the PR, Jim! I published a new release with your changes.