search

RedMadRobot / figma-export

Command line utility to export colors, typography, icons and images from Figma to Xcode / Android Studio project
MIT License
726 stars 114 forks source link

Add On-Demand Resource Tags support #47

Closed NoFearJoe closed 3 years ago

NoFearJoe commented 3 years ago

Do you plan to add on-demand resource tags support in the nearest future?

subdan commented 3 years ago

I don‘t plan to add this feature because almost all iOS apps store resources locally.

NoFearJoe commented 3 years ago

What if I'll make a pull request with this feature? Or it's better to ask you to implement this?

subdan commented 3 years ago

It'll be cool. I will be glad to accept your PR. I don‘t plan to implement it myself.

I want to ask you some questions before you start.

  1. How will the designer specify the tags for a group of resources in Figma file?

  2. Which project files do you want to edit/add? E.g. edit *.pbxproj and *.imagset/Contents.json.

  3. How a programmer can get access to the on-demand resources? Do you plan to generate code to obtain these resources?

  4. Does Android have a similar feature? Do you plan to implement only iOS part?

NoFearJoe commented 3 years ago
  1. I haven't thought about it yet. Maybe it will be implemented with a separated frame with a special prefix (on-demand, for example). But first I have to dive into your code to better understand how to implement this.
  2. I guess I will only add tags to *.imagset/Contents.json.
  3. Are you asking about obtaining the resources in runtime?
  4. No, I don't, because I haven't heard about this feature on Android.
subdan commented 3 years ago
  1. I think we should add tags to the description field of a component.
  2. When you add tag to a resource in an Assets.xcassets file, pbxproj file is also modified.
  3. Yep.

Do you want to use Prefetching Tags?

subdan commented 3 years ago

Hi, @NoFearJoe. Do you still want to implement this feature?

NoFearJoe commented 3 years ago

We've stopped implementing this feature in our project. So I am not going to implement On-Demand resources in near future.