search

RedNax67 / MMM-WunderGround

28 stars 43 forks source link

Make module translatable #1

Closed paviro closed 8 years ago

paviro commented 8 years ago

It would be awesome if you'd make the module translatable!

RedNax67 commented 8 years ago

UPDATE: Translation supported.... but like the original weatherforecast module, it only translates LOADING :)

Well, there isn't really any text in the module itself anymore. Anything readable comes from weather underground which will provide it in the language specified...

paviro commented 8 years ago

Here is another one else ;) Please set the correct winderground <i>apikey</i> in the config for module: " + this.name + "."

RedNax67 commented 8 years ago

Okok, added proper translation implementation. :D Feel free to send pull requests with more languages... Although i feel this particular translation should be in the core files.

paviro commented 8 years ago

Why don't you add it without the mention of winderground but just generic api key?

RedNax67 commented 8 years ago

The translation is already generic, the modulename gets added in the module itself..

wrapper.innerHTML = this.translate('APIKEY') + this.name + ".";
paviro commented 8 years ago

Ah haven't checked the new translation, we'll send a pull request to Michael I am sure he'll add it :)