search

RedPRL / asai

🩺 A library for compiler diagnostics
https://ocaml.org/p/asai
Apache License 2.0
35 stars 2 forks source link

⛓️‍💥 Change the name of the argument `line_breaks`? #143

Closed favonia closed 1 year ago

favonia commented 1 year ago

This is a minor issue, but I have been struggling with a good name for the argument to change the line breaking algorithm. It's taking `Traditional or `Unicode to indicate the mode:

val display : ... -> ?line_breaks:[`Unicode | `Traditional] -> ... -> Message.t Diagnostic.t -> unit

The ones coming into my mind include

  1. line_breaks
  2. line_breaking
  3. line_breaking_alg
  4. newlines

I wonder if some native speaker can help me out :laughing:

TOTBWF commented 1 year ago

Either line_breaks or line_break_strategy. I prefer the former because it is shorter :)

favonia commented 1 year ago

Alright, I'll keep the current name line_breaks, then.