search

RedPRL / cooltt

😎TT
http://www.redprl.org/
Apache License 2.0
217 stars 16 forks source link

Fixes flake.nix #403

Closed solomon-b closed 1 year ago

solomon-b commented 1 year ago

Rewrites flake.nix and pins some libraries to get the nix shell environment and nix builds working.

~Note that I had to pin Kado prior to 17206ca3d01fada34e34e60e1995b03609292b61 which has a breaking change.~

solomon-b commented 1 year ago

@favonia I hope you don't mind I rewrote the flake to match the polytt one.

favonia commented 1 year ago

@solomon-b Thank you! I believe cooltt does need the latest version of kado. (Concretely, Cof.cof was changed to Cof.t.)

In any case, we might also need you to to transfer copyright to "RedPRL Development Team" as in https://github.com/RedPRL/cooltt/pull/346. We can do it after this PR, though.

solomon-b commented 1 year ago

@solomon-b Thank you! I believe cooltt does need the latest version of kado. (Concretely, Cof.cof was changed to Cof.t.)

Oh I must have been on an old cooltt commit. I've updated the pin and all is working.

In any case, we might also need you to to transfer copyright to "RedPRL Development Team" as in #346. We can do it after this PR, though.

No problem!

favonia commented 1 year ago

@solomon-b Yeah! Thank you!

favonia commented 12 months ago

@solomon-b I have two questions: (1) What name do you want us to put into CONTRIBUTORS.md for you? (I plan to start a PR to add your name.) (2) Do you have a ready-to-use GitHub Actions template that tests the Nix files?

solomon-b commented 12 months ago

@solomon-b I have two questions: (1) What name do you want us to put into CONTRIBUTORS.md for you? (I plan to start a PR to add your name.) (2) Do you have a ready-to-use GitHub Actions template that tests the Nix files?

You can put me under Solomon Bothwell.

I don't have an ocaml specific nix github CI action but I can try to throw something together.

favonia commented 12 months ago

@solomon-b Thanks. Just to clarify that the GitHub Actions is not urgent (and I thought your project could benefit from it too).