RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
37 stars 67 forks source link

Double damage dices when disaventage roll contain a critical success #148

Open Rehvaro opened 4 years ago

Rehvaro commented 4 years ago

Hello,

I use : Foundry 0.7.5 System DnD5e 0.98 Module Better Rolls (Only) 1.1.17

The problem i have is that when I do a roll with disadvantage, it take the lower one as expected but if the other dice is a critical success, then if launch 2 damages dices as if the chosen attack dice was the critical success one.

Here to examples (with critical range set to 10+): crits

On the first one 18 is critical, 14 is the chosen dice. On the second one, 12 is critical, 4 is the chosen dice.

On the first example both results are Crits, so it's normal to have double damages, but on the second example it's not normal and double damages shouldn't be done because the chosen dice isn't a critical success.

I hope this report can help you

Best regards,

mikkosaarinen commented 3 years ago

I'm also a little bit confused

This was a normal roll, so the first dice should be taken into account (10). So my damage would be 1d8(4) + 2 + 3 = 9. How can I select the normal damage from the chat box? Shouldn't there be two damage rolls, like there are two attack rolls, one with critical and one without?

image

Maybe there is an option I'm missing?

CarlosFdez commented 3 years ago

When you apply damage, there's a dialog box to confirm whether to apply critical or not.

This is the reason btw that I prefer the single roll workflow (with the -/+ buttons). That 5 undefined is definitely a bug though, don't know how you managed to get that to appear